My grandmother, mother & aunts all make the same potato salad from scratch:
cubed boiled potatoes, no skins
mayo
mustard
chopped celery
finely chopped onion
chopped hardboiled eggs
^^for my uncle Pete they always make a separate Cool Whip dish of potato salad with no eggs.