I make it the same way my mom has always made hers diced peeled potatoes as she says she uses the ones that are white in the middle lol she adds a bit of yellow mustard for color more than flavor real mayo onion dill pickles hard boiled eggs it’s semi mashed with some chunks left for texture I’ve always loved it and she brings it every thanksgiving and sometimes for christmas it’s my present lol 🙂